flyteplugins icon indicating copy to clipboard operation
flyteplugins copied to clipboard

Add support raw container in the map task

Open pingsutw opened this issue 2 years ago • 1 comments

TL;DR

When using regular task in the map task, the entrypoint is pyflyte-map-execute. it does two things before running the task.

  1. Update sub task input / output interface to list interface
  2. Append job id to output prefix

However, when using raw container, the entrypoint will not be pyflyte-map-execute.

Therefore, we should update the output prefix for copilot, and support upload collection in the copilot.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [x] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

image

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1678230956906899

Follow-up issue

NA

pingsutw avatar Mar 09 '23 23:03 pingsutw

Codecov Report

Merging #329 (3a6cc0b) into master (18a594e) will increase coverage by 1.39%. The diff coverage is 68.75%.

:exclamation: Current head 3a6cc0b differs from pull request most recent head b80c8a9. Consider uploading reports for the commit b80c8a9 to get more accurate results

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   62.65%   64.05%   +1.39%     
==========================================
  Files         146      146              
  Lines       12220     9929    -2291     
==========================================
- Hits         7657     6360    -1297     
+ Misses       3981     2985     -996     
- Partials      582      584       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/core/transition.go 100.00% <ø> (ø)
go/tasks/pluginmachinery/flytek8s/pod_helper.go 69.81% <ø> (-3.21%) :arrow_down:
go/tasks/pluginmachinery/internal/webapi/core.go 25.00% <0.00%> (+2.27%) :arrow_up:
go/tasks/plugins/hive/executor.go 10.12% <0.00%> (+1.87%) :arrow_up:
go/tasks/plugins/presto/executor.go 11.26% <0.00%> (+1.96%) :arrow_up:
...tasks/pluginmachinery/flytek8s/container_helper.go 87.41% <40.00%> (+0.23%) :arrow_up:
go/tasks/plugins/array/k8s/subtask_exec_context.go 80.80% <66.66%> (+0.97%) :arrow_up:
go/tasks/plugins/array/catalog.go 46.98% <68.18%> (+1.93%) :arrow_up:
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) :arrow_up:
go/tasks/plugins/array/k8s/management.go 57.43% <100.00%> (-0.90%) :arrow_down:
... and 1 more

... and 120 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 10 '23 22:03 codecov[bot]