flyteplugins
flyteplugins copied to clipboard
[WIP] Out of core plugin
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
- [ ] Bug Fix
- [ ] Feature
- [ ] Plugin
Are all requirements met?
- [ ] Code completed
- [ ] Smoke tested
- [ ] Unit tests added
- [ ] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
Codecov Report
Merging #311 (9aaa9cb) into master (5981c35) will increase coverage by
0.75%. The diff coverage is17.27%.
:exclamation: Current head 9aaa9cb differs from pull request most recent head 1c20b26. Consider uploading reports for the commit 1c20b26 to get more accurate results
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 62.90% 63.66% +0.75%
==========================================
Files 146 148 +2
Lines 12162 9961 -2201
==========================================
- Hits 7651 6342 -1309
+ Misses 3934 3041 -893
- Partials 577 578 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| go/tasks/pluginmachinery/internal/webapi/core.go | 24.10% <0.00%> (+1.37%) |
:arrow_up: |
| ...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go | 75.00% <ø> (-0.48%) |
:arrow_down: |
| go/tasks/plugins/webapi/databricks/plugin.go | 66.32% <0.00%> (+3.39%) |
:arrow_up: |
| go/tasks/plugins/webapi/snowflake/plugin.go | 66.25% <0.00%> (+4.01%) |
:arrow_up: |
| go/tasks/plugins/webapi/grpc/plugin.go | 8.79% <8.79%> (ø) |
|
| go/tasks/pluginmachinery/flytek8s/pod_helper.go | 72.54% <100.00%> (-2.73%) |
:arrow_down: |
| ...o/tasks/pluginmachinery/internal/webapi/metrics.go | 100.00% <100.00%> (ø) |
|
| go/tasks/plugins/webapi/grpc/config.go | 100.00% <100.00%> (ø) |
|
| go/tasks/plugins/array/inputs.go | 83.33% <0.00%> (-4.91%) |
:arrow_down: |
| .../pluginmachinery/internal/webapi/plugin_context.go | 50.00% <0.00%> (-3.85%) |
:arrow_down: |
| ... and 128 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.