flyteplugins icon indicating copy to clipboard operation
flyteplugins copied to clipboard

Add GetOutputMetadata to the output reader

Open pingsutw opened this issue 3 years ago • 1 comments

TL;DR

Add GetOutputMetadata to the output reader, so the propeller can retrieve the deck path by calling this method.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [x] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://github.com/flyteorg/flyte/issues/2603

Follow-up issue

https://github.com/flyteorg/flytepropeller/pull/494

pingsutw avatar Oct 12 '22 16:10 pingsutw

Codecov Report

Merging #289 (4fa6067) into master (eed7326) will increase coverage by 0.00%. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files         145      145           
  Lines        9311     9317    +6     
=======================================
+ Hits         5896     5900    +4     
- Misses       2872     2873    +1     
- Partials      543      544    +1     
Flag Coverage Δ
unittests 62.73% <50.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/pluginmachinery/core/allocationstatus_enumer.go 0.00% <ø> (ø)
go/tasks/pluginmachinery/core/phase_enumer.go 13.33% <ø> (ø)
...asks/pluginmachinery/core/transitiontype_enumer.go 13.33% <ø> (ø)
...inery/flytek8s/resourcecustomizationmode_enumer.go 13.33% <ø> (ø)
...ks/pluginmachinery/internal/webapi/phase_enumer.go 13.33% <ø> (ø)
go/tasks/pluginmachinery/ioutils/paths.go 84.61% <ø> (ø)
...sks/pluginmachinery/workqueue/workstatus_enumer.go 13.33% <ø> (ø)
go/tasks/plugins/array/core/phase_enumer.go 13.33% <ø> (ø)
...pluginmachinery/ioutils/in_memory_output_reader.go 65.21% <50.00%> (-3.21%) :arrow_down:
...uginmachinery/ioutils/remote_file_output_reader.go 22.07% <100.00%> (+2.07%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 12 '22 17:10 codecov[bot]