flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Bump timeout in integration tests to 10 minutes

Open eapolinario opened this issue 10 months ago • 4 comments

Tracking issue

NA

Why are the changes needed?

We're seeing some of the tests in the integration test suite fail semi-frequently. After investigating with https://github.com/tmate-io/tmate here I confirmed that the tasks end executing successfully, but the flyteremote call only waits for 5 minutes.

What changes were proposed in this pull request?

Set a unified timeout of 10 min per execution in flyteremote integration tests.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

Summary by Bito

PR extends integration test timeout from 5 to 10 minutes by introducing TIMEOUT_IN_MIN constant and updating all remote.wait() calls. This change addresses semi-frequent test failures and ensures consistent timeout behavior across the test suite.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

eapolinario avatar Feb 19 '25 22:02 eapolinario