flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

update ollama plugin to reflect API changes

Open samhita-alla opened this issue 11 months ago • 5 comments

Tracking issue

Why are the changes needed?

The Ollama Python API and backend were updated, necessitating unpinning the version and making adjustments to the plugin to ensure compatibility.

What changes were proposed in this pull request?

Replaced the modelfile field with individual fields that correspond directly to the attributes previously defined in the modelfile.

How was this patch tested?

There's an end-to-end example available, and I've tested it—it works as expected.

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

samhita-alla avatar Jan 16 '25 09:01 samhita-alla

Code Review Agent Run Status

  • Limitations and other issues:  Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

flyte-bot avatar Jan 16 '25 09:01 flyte-bot

Code Review Agent Run Status

  • Limitations and other issues:  Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

flyte-bot avatar Jan 16 '25 11:01 flyte-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.94%. Comparing base (4b50681) to head (2a5b51c). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
- Coverage   79.53%   76.94%   -2.59%     
==========================================
  Files         202      270      +68     
  Lines       21370    23897    +2527     
  Branches     2746     2746              
==========================================
+ Hits        16997    18388    +1391     
- Misses       3603     4737    +1134     
- Partials      770      772       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 16 '25 11:01 codecov[bot]

Code Review Agent Run Status

  • Limitations and other issues:  Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

flyte-bot avatar Jan 16 '25 14:01 flyte-bot

Code Review Agent Run Status

  • Limitations and other issues:  Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

flyte-bot avatar Jan 16 '25 15:01 flyte-bot