flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Always print traceback

Open pingsutw opened this issue 1 year ago • 1 comments

Tracking issue

NA

Why are the changes needed?

It’s difficult to identify which function failed when encountering a gRPC error

What changes were proposed in this pull request?

Always print the traceback after we get a grpc error.

How was this patch tested?

Raise a grpc error in the create_execution method in raw.py

pingsutw avatar Nov 27 '24 21:11 pingsutw

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.79%. Comparing base (f938661) to head (8cf8c6d). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
+ Coverage   75.14%   82.79%   +7.64%     
==========================================
  Files         200        3     -197     
  Lines       20919      186   -20733     
  Branches     2692        0    -2692     
==========================================
- Hits        15720      154   -15566     
+ Misses       4445       32    -4413     
+ Partials      754        0     -754     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '24 22:11 codecov[bot]