flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Add error message when docker isn't running

Open dansola opened this issue 1 year ago • 1 comments

Why are the changes needed?

When a user isn't running docker, it is unclear when they see the logs:

Running Execution on Remote.
Failed to check if the image exists with error:
 Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))
Flytekit assumes the image ghcr.io/dansola/test-image:ppjeS9H6wavg5FvXbowKEQ already exists.

Ideally we'd have more clear logs when we can narrow down that the issue is that docker isn't running.

What changes were proposed in this pull request?

Added additional logging.

How was this patch tested?

Did not run docker, ran pyflyte run --remote with an ImangeSpec, observed the log message:

Running Execution on Remote.
Unable to connect to Docker daemon. Please ensure Docker is installed and running.
You can start Docker by:
  - Windows/Mac: Start the Docker Desktop application
  - Linux: Run 'sudo systemctl start docker'
Flytekit assumes the image ghcr.io/dansola/test-image:ORI1BZVtVKVludLUJsq_Rg already exists.

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

dansola avatar Nov 20 '24 01:11 dansola

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.00%. Comparing base (faee3da) to head (af94679). Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2942       +/-   ##
===========================================
+ Coverage   79.32%   94.00%   +14.68%     
===========================================
  Files         199       38      -161     
  Lines       20870     1768    -19102     
  Branches     2684        0     -2684     
===========================================
- Hits        16555     1662    -14893     
+ Misses       3566      106     -3460     
+ Partials      749        0      -749     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Nov 20 '24 02:11 codecov[bot]