flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

try more complete lifecycle

Open wild-endeavor opened this issue 1 year ago • 2 comments

into https://github.com/flyteorg/flytekit/pull/2737

wild-endeavor avatar Sep 11 '24 08:09 wild-endeavor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.78%. Comparing base (7b4899a) to head (c16b4d7).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           async-loop-issue    #2744       +/-   ##
=====================================================
+ Coverage             45.40%   90.78%   +45.38%     
=====================================================
  Files                   194       57      -137     
  Lines                 19685     2842    -16843     
  Branches               2854        0     -2854     
=====================================================
- Hits                   8937     2580     -6357     
+ Misses                10301      262    -10039     
+ Partials                447        0      -447     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 11 '24 11:09 codecov[bot]

@thomasjpfan @pingsutw what do you think about this pr + https://github.com/unionai/unionai/pull/402 and maybe taking into account the windows policy?

wild-endeavor avatar Sep 12 '24 01:09 wild-endeavor