flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

feat: Allow overriding package versions

Open nightscape opened this issue 1 year ago • 4 comments

Tracking issue

Closes https://github.com/flyteorg/flyte/issues/5597

Why are the changes needed?

See https://github.com/flyteorg/flyte/issues/5597

What changes were proposed in this pull request?

How was this patch tested?

Not yet

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [X] All new and existing tests passed.
  • [X] All commits are signed-off.

Related PRs

Docs link

nightscape avatar Jul 27 '24 09:07 nightscape

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Jul 27 '24 09:07 welcome[bot]

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.44%. Comparing base (37e4fad) to head (9f05341). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/image_spec/image_spec.py 22.22% 7 Missing :warning:
flytekit/image_spec/default_builder.py 0.00% 2 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (37e4fad) and HEAD (9f05341). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (37e4fad) HEAD (9f05341)
17 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2616       +/-   ##
===========================================
- Coverage   80.57%   45.44%   -35.14%     
===========================================
  Files         260      196       -64     
  Lines       23778    20310     -3468     
  Branches     2618     2619        +1     
===========================================
- Hits        19160     9230     -9930     
- Misses       3922    10632     +6710     
+ Partials      696      448      -248     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 09:10 codecov[bot]

Could someone have a look at this, maybe @eapolinario ?

nightscape avatar Oct 22 '24 09:10 nightscape

I left a comment in the original issue. Let's follow up there before deciding if this PR is still applicable.

eapolinario avatar Nov 11 '24 20:11 eapolinario