flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Adds comet-ml plugin

Open thomasjpfan opened this issue 1 year ago • 1 comments

Why are the changes needed?

This PR adds a comet-ml plugin to flytekit.

What changes were proposed in this pull request?

This PR adds a comet_ml_init task decorator that adds a link to the Comet's platform.

How was this patch tested?

Unit tests were added to this PR.

Screenshots

Screenshot 2024-07-02 at 11 02 07 PM

Related PRs

Related to https://github.com/flyteorg/flytekit/pull/2405

Docs link

I also added an example in flytesnacks: https://github.com/flyteorg/flytesnacks/pull/1702

thomasjpfan avatar Jul 03 '24 03:07 thomasjpfan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.41%. Comparing base (876877a) to head (58b33b0). Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2550       +/-   ##
===========================================
+ Coverage   52.89%   90.41%   +37.52%     
===========================================
  Files         297       60      -237     
  Lines       23957     3058    -20899     
  Branches     3655        0     -3655     
===========================================
- Hits        12671     2765     -9906     
+ Misses      11178      293    -10885     
+ Partials      108        0      -108     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 03 '24 03:07 codecov[bot]

@thomasjpfan Can we add flytekitplugins-comet-ml in the file below? It will help us run the CI to build the plugin.

https://github.com/flyteorg/flytekit/blob/master/.github/workflows/pythonbuild.yml#L319

Future-Outlier avatar Jul 17 '24 18:07 Future-Outlier