flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Add Perian Job Platform agent

Open otarabai opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Adding a new agent to run Flyte tasks on the Perian Job Platform (perian.io).

How was this patch tested?

  • Unit tests
  • Testing against local sandbox cluster

Setup process

See README.md

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

otarabai avatar Jun 27 '24 13:06 otarabai

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Jun 27 '24 13:06 welcome[bot]

This is amazing! 👍 People can easily run a task on a GPU node.

pingsutw avatar Jul 09 '24 19:07 pingsutw

@EngHabu Could you re-approve after a small change? @pingsutw Let me know there are other blockers for approval! Thanks guys!

otarabai avatar Jul 13 '24 11:07 otarabai

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.54%. Comparing base (647b071) to head (fa797e9). Report is 138 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
- Coverage   91.30%   88.54%   -2.77%     
==========================================
  Files          78       71       -7     
  Lines        3968     3377     -591     
==========================================
- Hits         3623     2990     -633     
- Misses        345      387      +42     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 01:08 codecov[bot]

@otarabai , can you fix the lint error? Also, if you merge master the errors in the greatexpectations should go away.

eapolinario avatar Aug 29 '24 14:08 eapolinario

@eapolinario Thanks for the note Eduardo. I just rebased, fixed the lint errors and squashed.

otarabai avatar Aug 29 '24 17:08 otarabai

Congrats on merging your first pull request! 🎉

welcome[bot] avatar Aug 29 '24 21:08 welcome[bot]