flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Improvement: accept int value for Resources

Open lowc1012 opened this issue 1 year ago • 3 comments

Tracking issue

Closes flyteorg/flyte #4691

Why are the changes needed?

Make str and int available for mem, gpu and ephemeral_storage. Make str, int, float available for cpu.

What changes were proposed in this pull request?

Update Resources class in flytekit/core/resources.py

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

Docs link

lowc1012 avatar Feb 16 '24 11:02 lowc1012

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Feb 16 '24 11:02 welcome[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.59%. Comparing base (bf38b8e) to head (9976397). Report is 4 commits behind head on master.

:exclamation: Current head 9976397 differs from pull request most recent head 1c6be50. Consider uploading reports for the commit 1c6be50 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   83.04%   80.59%   -2.45%     
==========================================
  Files         324      180     -144     
  Lines       24861    17856    -7005     
  Branches     3547     3483      -64     
==========================================
- Hits        20645    14391    -6254     
+ Misses       3591     2843     -748     
+ Partials      625      622       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 18:02 codecov[bot]

Can you merge master ?

eapolinario avatar Mar 26 '24 23:03 eapolinario

Congrats on merging your first pull request! 🎉

welcome[bot] avatar Apr 30 '24 13:04 welcome[bot]