flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

[wip] propeller-log-links-bug-test

Open Future-Outlier opened this issue 1 year ago • 3 comments

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

Future-Outlier avatar Jan 30 '24 10:01 Future-Outlier

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f115157) 85.77% compared to head (20508f0) 83.00%. Report is 38 commits behind head on master.

:exclamation: Current head 20508f0 differs from pull request most recent head e45a196. Consider uploading reports for the commit e45a196 to get more accurate results

Files Patch % Lines
flytekit/sensor/sensor_engine.py 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   85.77%   83.00%   -2.77%     
==========================================
  Files         313      176     -137     
  Lines       23541    17121    -6420     
  Branches     3520     3531      +11     
==========================================
- Hits        20193    14212    -5981     
+ Misses       2738     2298     -440     
- Partials      610      611       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 10:01 codecov[bot]

PENDING image SUCCESS image

Future-Outlier avatar Jan 30 '24 11:01 Future-Outlier

example

from flytekit.sensor.file_sensor import FileSensor
from flytekit import ImageSpec, task, workflow
# import sys

# flytekit = "git+https://github.com/Future-Outlier/flytekit.git@98ddd542a02551a9a9eb122b98004d0d092abbe9"
# image_spec = ImageSpec(
#     packages=[flytekit],
#     apt_packages=["git"],
#     registry="futureoutlier",
# )

sensor = FileSensor(name="test_sensor")

@task()
def t1():
    return

@workflow()
def wf():
    # sensor(path="s3://my-s3-bucket") >> t1()
    # sensor(path="/tmp") >> t1()
    sensor(path="/flyte_testing") >> t1()

if __name__ == "__main__":
    wf()

Future-Outlier avatar Jan 30 '24 11:01 Future-Outlier