flytekit
flytekit copied to clipboard
Flyte issue #4691 Add support passing integer to flytekit.resource
Flyte issue #4691 https://github.com/flyteorg/flyte/issues/4691
Added support for passing string as well as integer to flytekit.resource
Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line:
- Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
- Sign off your commits (Reference: DCO Guide).
Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.
Comparison is base (
f22cec2) 81.08% compared to head (65fd20c) 54.44%. Report is 1 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| flytekit/core/resources.py | 63.15% | 7 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2096 +/- ##
===========================================
- Coverage 81.08% 54.44% -26.64%
===========================================
Files 176 176
Lines 17040 17040
Branches 3512 3512
===========================================
- Hits 13817 9278 -4539
- Misses 2644 7340 +4696
+ Partials 579 422 -157
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @Shenr0n any updates on this