flytekit
flytekit copied to clipboard
[FlyteCTL Feature] save registration process results into result_dir
TL;DR
Save info about registered entities into a json/.yaml file
Type
- [ ] Bug Fix
- [x] Feature
- [ ] Plugin
Are all requirements met?
- [x] Code completed
- [x] Smoke tested
- [x] Unit tests added
- [ ] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
WDYT about chosen arguments' names?
Tracking Issue
https://github.com/flyteorg/flyte/issues/3919
Follow-up issue
NA
Codecov Report
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
e41ec1e
) 94.95% compared to head (d69dd5c
) 51.03%. Report is 43 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
flytekit/tools/repo.py | 46.15% | 6 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1904 +/- ##
===========================================
- Coverage 94.95% 51.03% -43.92%
===========================================
Files 136 171 +35
Lines 6165 16833 +10668
Branches 0 3493 +3493
===========================================
+ Hits 5854 8591 +2737
- Misses 311 7819 +7508
- Partials 0 423 +423
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@eapolinario @pingsutw can you please review this PR?
@wckdman, can you resolve the merge conflict?
@samhita-alla Done ✅
@samhita-alla @eapolinario @pingsutw ping :)