flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Upload Flytekit runtime metrics to S3

Open Yicheng-Lu-llll opened this issue 1 year ago • 1 comments

TL;DR

This is part of Flytekit Metrics Exploration.

This PR uploads all the flytekit metrics to the remote storage(highlighted in green). image

Flytekit Metrics Exploration includes:

  • flytekit: https://github.com/flyteorg/flytekit/pull/1683

  • flyteplugins: https://github.com/flyteorg/flyteplugins/pull/361

  • flyteidl: https://github.com/flyteorg/flyteidl/pull/415

  • flytepropeller: https://github.com/flyteorg/flytepropeller/pull/577

  • flyteadmin: https://github.com/flyteorg/flyteadmin/pull/575

Checks

ran task in the sand box, the span file is under the same folder with deck.html. image image

Yicheng-Lu-llll avatar Jun 08 '23 23:06 Yicheng-Lu-llll

Codecov Report

Merging #1683 (9c8c2ee) into master (3370a96) will increase coverage by 0.00%. The diff coverage is 73.91%.

:exclamation: Current head 9c8c2ee differs from pull request most recent head 767335a. Consider uploading reports for the commit 767335a to get more accurate results

@@           Coverage Diff           @@
##           master    #1683   +/-   ##
=======================================
  Coverage   71.03%   71.03%           
=======================================
  Files         336      336           
  Lines       30798    30813   +15     
  Branches     5589     5590    +1     
=======================================
+ Hits        21876    21889   +13     
- Misses       8375     8378    +3     
+ Partials      547      546    -1     
Impacted Files Coverage Δ
flytekit/core/base_task.py 48.32% <ø> (ø)
flytekit/core/constants.py 0.00% <0.00%> (ø)
flytekit/deck/deck.py 52.63% <66.66%> (ø)
flytekit/core/utils.py 62.37% <83.33%> (+2.14%) :arrow_up:

... and 4 files with indirect coverage changes

codecov[bot] avatar Jun 09 '23 17:06 codecov[bot]