flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

feat: Add pydantic workflow fetching to remote

Open ggydush opened this issue 2 years ago • 2 comments

TL;DR

Add dynamic Pydantic workflow creation to FlyteRemote. We will likely change entrypoint, but this is a starting point.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

ggydush avatar Apr 17 '23 18:04 ggydush

Codecov Report

Merging #1594 (b478441) into master (e865db5) will decrease coverage by 0.18%. The diff coverage is 29.77%.

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
- Coverage   70.04%   69.86%   -0.18%     
==========================================
  Files         326      327       +1     
  Lines       29913    30044     +131     
  Branches     5391     5411      +20     
==========================================
+ Hits        20952    20991      +39     
- Misses       8437     8528      +91     
- Partials      524      525       +1     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
flytekit/remote/remote.py 39.80% <28.57%> (-0.14%) :arrow_down:
flytekit/remote/pydantic_workflow_interface.py 29.83% <29.83%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Apr 17 '23 18:04 codecov[bot]

how about that idea of moving this to a separate plugin?

eapolinario avatar May 02 '23 20:05 eapolinario