flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

TypeTransformer for TensorFlow Tensor

Open samhita-alla opened this issue 3 years ago • 2 comments

TL;DR

Primary PR: https://github.com/flyteorg/flytekit/pull/1269

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

samhita-alla avatar Nov 28 '22 07:11 samhita-alla

Codecov Report

Merging #1354 (57dca89) into master (7cf5b68) will decrease coverage by 1.28%. The diff coverage is 92.15%.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   70.41%   69.13%   -1.29%     
==========================================
  Files         291      295       +4     
  Lines       25594    26799    +1205     
  Branches     2129     2516     +387     
==========================================
+ Hits        18023    18527     +504     
- Misses       7083     7778     +695     
- Partials      488      494       +6     
Impacted Files Coverage Δ
flytekit/extras/tensorflow/__init__.py 55.55% <55.55%> (ø)
flytekit/extras/tensorflow/tensor.py 89.18% <89.18%> (ø)
...sts/flytekit/unit/extras/tensorflow/test_tensor.py 100.00% <100.00%> (ø)
...kit/unit/extras/tensorflow/test_transformations.py 100.00% <100.00%> (ø)
tests/flytekit/unit/core/tracker/d.py 40.00% <0.00%> (-10.00%) :arrow_down:
flytekit/models/execution.py 42.20% <0.00%> (-9.43%) :arrow_down:
flytekit/models/core/workflow.py 42.63% <0.00%> (-9.26%) :arrow_down:
flytekit/models/core/identifier.py 38.70% <0.00%> (-8.66%) :arrow_down:
flytekit/models/dynamic_job.py 37.50% <0.00%> (-8.66%) :arrow_down:
flytekit/models/project.py 34.28% <0.00%> (-8.58%) :arrow_down:
... and 156 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 28 '22 09:11 codecov[bot]

Eventually we should use the streaming constructs for all of these types

kumare3 avatar Feb 17 '23 17:02 kumare3