flytekit
flytekit copied to clipboard
SSL Pyflyte Gcloud
Type
- [ ] Bug Fix
- [ ] Feature
- [ ] Plugin
- [X] Documentation
Are all requirements met?
- [ ] Code completed
- [ ] Smoke tested
- [ ] Unit tests added
- [X] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
Completed editing documentation on “How to add SSL while using pyflyte run on gcloud cluster”
Tracking Issue
https://github.com/flyteorg/flyte/issues/2893
Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line:
- Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
- Sign off your commits (Reference: DCO Guide).
Codecov Report
Merging #1253 (6fbd9b6) into master (b76cf84) will increase coverage by
0.43%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1253 +/- ##
==========================================
+ Coverage 68.65% 69.08% +0.43%
==========================================
Files 288 295 +7
Lines 26351 26928 +577
Branches 2489 2531 +42
==========================================
+ Hits 18092 18604 +512
- Misses 7779 7829 +50
- Partials 480 495 +15
Impacted Files | Coverage Δ | |
---|---|---|
flytekit/tools/fast_registration.py | 81.53% <0.00%> (-7.53%) |
:arrow_down: |
flytekit/core/container_task.py | 27.45% <0.00%> (-2.10%) |
:arrow_down: |
flytekit/remote/remote.py | 40.51% <0.00%> (-1.05%) |
:arrow_down: |
flytekit/configuration/__init__.py | 36.87% <0.00%> (-0.67%) |
:arrow_down: |
flytekit/models/core/identifier.py | 38.70% <0.00%> (-0.62%) |
:arrow_down: |
flytekit/core/python_auto_container.py | 49.54% <0.00%> (-0.46%) |
:arrow_down: |
tests/flytekit/unit/core/test_type_delayed.py | 96.42% <0.00%> (-0.35%) |
:arrow_down: |
...kit/unit/types/structured_dataset/test_bigquery.py | 97.05% <0.00%> (-0.24%) |
:arrow_down: |
tests/flytekit/unit/core/test_interface.py | 85.49% <0.00%> (-0.23%) |
:arrow_down: |
flytekit/tools/serialize_helpers.py | 92.53% <0.00%> (-0.22%) |
:arrow_down: |
... and 50 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@Smartmind12, you'll need to edit the https://docs.flyte.org/en/latest/deployment/gcp/manual.html file in the flyte repo. Also, the instructions need to be modified to align the doc flow with flyte docs (the doc is actually pretty clear). Can you do that?
@Smartmind12, you'll need to edit the https://docs.flyte.org/en/latest/deployment/gcp/manual.html file in the flyte repo. Also, the instructions need to be modified to align the doc flow with flyte docs (the doc is actually pretty clear). Can you do that?
@samhita-alla I did not understand the second part ...as in what should i modify?
@Smartmind12, the content should be present in the gcp page I shared with you earlier. And if you see the instructions in the doc, it aligns with the content that's present on the gcp page. So you'll need to intersperse the gcp page with the doc instructions.
@Smartmind12, the content should be present in the gcp page I shared with you earlier. And if you see the instructions in the doc, it aligns with the content that's present on the gcp page. So you'll need to intersperse the gcp page with the doc instructions.
Hey @samhita-alla Sorry i got a little busy...so you want me to rearrange the contents of the gcp in the flow of the google drive doc ...is that right?
@Smartmind12 Could you add these changes to here instead?
Thank you!!