flytekit
flytekit copied to clipboard
Fixing structured dataset for empty bq tables
TL;DR
Structured dataset bq read fails on empty table because pandas.concat()
fails if the passed array is empty. Fix it to create an empty dataframe with the required schema
Type
- [X] Bug Fix
- [ ] Feature
- [ ] Plugin
Are all requirements met?
- [ ] Code completed
- [ ] Smoke tested
- [ ] Unit tests added
- [ ] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line:
- Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
- Sign off your commits (Reference: DCO Guide).
Codecov Report
Merging #1157 (8ba3d61) into master (1c75bd1) will decrease coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 68.51% 68.50% -0.02%
==========================================
Files 288 288
Lines 26085 26089 +4
Branches 2918 2919 +1
==========================================
Hits 17871 17871
- Misses 7735 7739 +4
Partials 479 479
Impacted Files | Coverage Δ | |
---|---|---|
flytekit/types/structured/bigquery.py | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.