flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Add log streaming to papermill plugin

Open CalvinLeather opened this issue 3 years ago • 2 comments

TL;DR

Enabling the

Meant to open this in my fork for internal review, but will leave up as draft and wrap up tomorrow with a better test + smoke test.

Smoke test: image

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

CalvinLeather avatar Aug 10 '22 01:08 CalvinLeather

Codecov Report

Merging #1129 (c854024) into master (8d7efb0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files         287      287           
  Lines       25829    25829           
  Branches     2885     2885           
=======================================
  Hits        17633    17633           
  Misses       7719     7719           
  Partials      477      477           

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Aug 10 '22 01:08 codecov[bot]

@CalvinLeather is it ready to be merged?

pingsutw avatar Aug 29 '22 07:08 pingsutw

Kindly ping @CalvinLeather

pingsutw avatar Dec 22 '22 00:12 pingsutw

@pingsutw can we just cherry-pick the change and merge it in. I think this is a useful PR

kumare3 avatar Mar 29 '23 05:03 kumare3

Will do

pingsutw avatar Mar 29 '23 05:03 pingsutw