flyteidl icon indicating copy to clipboard operation
flyteidl copied to clipboard

Published 20 hours ago • verified publisher icon flyteorg

Events lineage

Open tnsetting opened this issue 4 years ago • 5 comments

TL;DR

This PR defines the schema for Flyte egress event. The goal is create a enrichment thread in flyteadmin which will populated these events by reading the raw events.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/1019

Follow-up issue

NA OR https://github.com/lyft/flyte/issues/

tnsetting avatar May 03 '21 14:05 tnsetting

@kumare3 PTAL. Thanks

tnsetting avatar May 06 '21 08:05 tnsetting

@tnsetting can you please update the description and link to an issue

kumare3 avatar May 06 '21 18:05 kumare3

@kumare3 Could you take another look for the PR?

tnsetting avatar Jun 07 '21 12:06 tnsetting

mind adding comments in general to the new proto messages?

katrogan avatar Jun 08 '21 20:06 katrogan

@tnsetting Please be mindful of the naming conventions for proto fields. See https://developers.google.com/protocol-buffers/docs/style#message_and_field_names

kanterov avatar Jun 09 '21 16:06 kanterov