flyteidl icon indicating copy to clipboard operation
flyteidl copied to clipboard

Pull Boilerplate Code & Update update.cfg

Open samhita-alla opened this issue 4 years ago • 3 comments
trafficstars

Signed-off-by: Samhita Alla [email protected]

TL;DR

Updated boilerplate in this repo. Added flyte entry in update.cfg file.

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA OR https://github.com/lyft/flyte/issues/

samhita-alla avatar Apr 21 '21 07:04 samhita-alla

@kumare3 Can you let me know if this is the right way to update the boilerplate code? If so, we'll have to update the update.cfg file in the concerned repos which have the boilerplate repo, after which we'll have to update (make update_boilerplate command) the boilerplate code again to copy the flyte repo which has the yaml file for the welcome bot.

Moreover, boilerplate isn't present in all flyteorg repos. Do we need to add it in all the repos?

samhita-alla avatar Apr 21 '21 09:04 samhita-alla

@samhita-alla yes you are right. This is how boilerplate works. And ideally it should be in all flyteorg repos

kumare3 avatar Apr 22 '21 17:04 kumare3

cc @katrogan

kumare3 avatar Apr 28 '21 18:04 kumare3