flytectl icon indicating copy to clipboard operation
flytectl copied to clipboard

Remove sandbox command

Open pingsutw opened this issue 1 year ago • 3 comments

TL;DR

The sandbox command has already been deprecated for a while; we can remove it now.

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

NA

Follow-up issue

NA

pingsutw avatar Feb 14 '24 19:02 pingsutw

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9c87165) 67.69% compared to head (659723f) 67.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   67.69%   67.66%   -0.03%     
==========================================
  Files         148      143       -5     
  Lines        6639     6575      -64     
==========================================
- Hits         4494     4449      -45     
+ Misses       1855     1841      -14     
+ Partials      290      285       -5     
Flag Coverage Δ
unittests 67.66% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 20:02 codecov[bot]

@pingsutw We should probably move the references in flyte repo before removing this command from flytectl https://github.com/search?q=repo%3Aflyteorg%2Fflyte%20%22flytectl%20sandbox%22&type=code

pmahindrakar-oss avatar Feb 26 '24 18:02 pmahindrakar-oss

https://github.com/flyteorg/flyte/pull/5034

pingsutw avatar Mar 10 '24 12:03 pingsutw