flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

Reuse existing executionClusterLabel value during relaunch #minor

Open va6996 opened this issue 1 year ago • 7 comments

TL;DR

Support execution cluster labels in flyteconsole. Additionally, reuse existing executionClusterLabel (if available from workflow execution) value for relaunching workflow/tasks

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [x] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

When a user specifies the execution cluster label for a single execution, that information is lost when the user clicks relaunch. This change automatically sets the execution cluster to the value set in the original workflow. Subsequent changes to allow specifying the cluster label via UI can be taken up later.

Tracking Issue

NA

Follow-up issue

NA

va6996 avatar May 14 '24 23:05 va6996

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar May 14 '24 23:05 welcome[bot]

Hey @va6996, sorry for the delay in reviewing your PR; it looks good but there is a minor merge conflict. But its approved now so we can merge it once the conflict is resolved 👍

jsonporter avatar Jul 11 '24 17:07 jsonporter

@jsonporter could you take a look again? the review got dismissed

va6996 avatar Jul 11 '24 17:07 va6996

@va6996 , can you add a screenshot of the launch form with the executionClusterLabel value pre-filled?

eapolinario avatar Aug 13 '24 20:08 eapolinario

@va6996 , can you add a screenshot of the launch form with the executionClusterLabel value pre-filled?

Hi @eapolinario this change did not modify the UI. The cluster details were passed through, based on the current label. This fixed the immediate issue where if a user relaunched a workflow (originally in a custom cluster), the workflow got launched in a different (default) cluster.

va6996 avatar Aug 13 '24 21:08 va6996

@FrankFlitton , can you take a look?

eapolinario avatar Aug 13 '24 21:08 eapolinario

@eapolinario @FrankFlitton updated based on the comments

va6996 avatar Aug 23 '24 23:08 va6996