flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

feat(log-panel): Add a button to show log panel in popup window

Open MortalHappiness opened this issue 10 months ago • 1 comments

TL;DR

Add a button to show log panel in popup window

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [x] Unit tests added
  • [x] Code documentation added
  • [x] Any pending items have an associated Issue

Complete description

https://github.com/flyteorg/flyteconsole/assets/47914085/a3b8d785-4588-4617-809e-eaaf43226b3e

Tracking Issue

Resolves: flyteorg/flyte#5108

Follow-up issue

NA

MortalHappiness avatar Mar 26 '24 09:03 MortalHappiness

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (7e0f2bd) to head (7a69c70).

:exclamation: Current head 7a69c70 differs from pull request most recent head aebdc40. Consider uploading reports for the commit aebdc40 to get more accurate results

Files Patch % Lines
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 44.44% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   54.74%   55.30%   +0.55%     
==========================================
  Files         578      564      -14     
  Lines       15153    14627     -526     
  Branches     2767     2667     -100     
==========================================
- Hits         8296     8089     -207     
+ Misses       6857     6538     -319     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 27 '24 16:03 codecov[bot]