flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

Support uploading files to Flyte blob store in the Flyte Console launch form

Open james-union opened this issue 2 years ago • 1 comments

https://github.com/flyteorg/flyte/issues/3317

https://localhost.development.uniondemo.run:3000/projects/flytesnacks/domains/development/workflows/flytefile_example.normalize_csv_file?duration=all

Right now the maximum file size is 1kb

Added FileInput

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Tracking Issue

fixes https://github.com/flyteorg/flyte/issues/3317

james-union avatar May 05 '23 10:05 james-union

Codecov Report

Merging #752 (bd00214) into master (e28a142) will decrease coverage by 0.08%. The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   66.09%   66.01%   -0.08%     
==========================================
  Files         488      489       +1     
  Lines       11806    11876      +70     
  Branches     2171     2184      +13     
==========================================
+ Hits         7803     7840      +37     
- Misses       4003     4036      +33     
Impacted Files Coverage Δ
...le/src/components/Launch/LaunchForm/UnionInput.tsx 27.77% <ø> (ø)
...onsole/src/components/Launch/LaunchForm/strings.ts 100.00% <ø> (ø)
.../console/src/components/Launch/LaunchForm/types.ts 100.00% <ø> (ø)
...le/src/components/common/FileUpload/FileUpload.tsx 68.42% <ø> (+68.42%) :arrow_up:
packages/console/src/models/Common/constants.ts 100.00% <ø> (ø)
...kages/console/src/components/hooks/useDataProxy.ts 42.85% <42.85%> (ø)
packages/console/src/models/Execution/api.ts 46.77% <50.00%> (+0.10%) :arrow_up:
...ole/src/components/Launch/LaunchForm/FileInput.tsx 61.11% <61.11%> (ø)
.../components/Launch/LaunchForm/LaunchFormInputs.tsx 84.37% <100.00%> (ø)
...components/Launch/LaunchForm/useFormInputsState.ts 97.56% <100.00%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar May 05 '23 10:05 codecov[bot]