flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

Paused State on timeline view

Open james-union opened this issue 2 years ago • 1 comments

Paused gate nodes were showing as running on timeline view. This PR fixes this.

image

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

Need to use getFrontNodePhase to get proper state of a gate node

james-union avatar Apr 03 '23 12:04 james-union

Codecov Report

Merging #740 (78d91da) into master (c82e755) will decrease coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   66.73%   66.64%   -0.09%     
==========================================
  Files         464      464              
  Lines       11390    11397       +7     
  Branches     2104     2105       +1     
==========================================
- Hits         7601     7596       -5     
- Misses       3789     3801      +12     
Impacted Files Coverage Δ
...ns/ExecutionDetails/Timeline/ExecutionTimeline.tsx 81.57% <100.00%> (+1.57%) :arrow_up:
...ecutionDetails/Timeline/TimelineChart/chartData.ts 66.66% <100.00%> (+0.75%) :arrow_up:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Apr 03 '23 12:04 codecov[bot]