flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

Include Archived workflows

Open james-union opened this issue 2 years ago • 3 comments

(https://github.com/flyteorg/flyte/issues/3433)

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

Sending [Archived, NonArchived] state with VALUE_IN filter operation to get all executions/tasks

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

https://github.com/flyteorg/flyte/issues/661

james-union avatar Jan 19 '23 17:01 james-union

@james-union can you please target master?

ursucarina avatar Jan 19 '23 17:01 ursucarina

Codecov Report

Merging #672 (63e24f5) into master (ffb161c) will decrease coverage by 0.17%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   66.95%   66.79%   -0.17%     
==========================================
  Files         455      456       +1     
  Lines       11280    11291      +11     
  Branches     2077     2076       -1     
==========================================
- Hits         7553     7542      -11     
- Misses       3727     3749      +22     
Impacted Files Coverage Δ
...orkflow/filters/useWorkflowIncludeArchivedState.ts 0.00% <0.00%> (ø)
...nsole/src/components/Entities/EntityExecutions.tsx 93.75% <ø> (ø)
...ole/src/components/Executions/ExecutionFilters.tsx 77.55% <ø> (ø)
...onsole/src/components/Project/ProjectDashboard.tsx 96.15% <ø> (ø)
...es/console/src/components/Project/ProjectTasks.tsx 100.00% <ø> (ø)
...ole/src/components/Task/SearchableTaskNameList.tsx 84.69% <ø> (ø)
...rc/components/common/FilterableNamedEntityList.tsx 94.11% <ø> (ø)
...nts/Executions/filters/useExecutionArchiveState.ts 90.00% <100.00%> (ø)
...onsole/src/components/Project/ProjectWorkflows.tsx 100.00% <100.00%> (ø)
...le/src/components/Task/useTaskShowArchivedState.ts 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 20 '23 01:01 codecov[bot]

@ursucarina I've rebased with master

james-union avatar Jan 20 '23 04:01 james-union