flyteadmin icon indicating copy to clipboard operation
flyteadmin copied to clipboard

real time deck support

Open Yicheng-Lu-llll opened this issue 1 year ago • 1 comments

TL;DR

This PR:

  1. stores DeckUri at task running stage to support real-time deck. with https://github.com/flyteorg/flytepropeller/pull/579, propeller can send node event with deck uri at running time, So, admin needs to also store the DeckUri inomation.

  2. In the CreateDownloadLink method, ensure to verify the existence of the URL prior to generating a signed URL. The console invokes CreateDownloadLink to convert the native deck URI into a signed URI. As indicated in FlytePropeller Pull Request #579, the deck URI may not exist yet, necessitating this validation step.

real time deck support includes:

  • flytekit: https://github.com/flyteorg/flytekit/pull/1704
  • flyteadmin: https://github.com/flyteorg/flyteadmin/pull/579
  • flytepropeller: https://github.com/flyteorg/flytepropeller/pull/579
  • flyteconsole: https://github.com/flyteorg/flyteconsole/pull/781

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

Yicheng-Lu-llll avatar Jun 22 '23 00:06 Yicheng-Lu-llll

Codecov Report

Merging #579 (02d399f) into master (949f5a2) will increase coverage by 1.53%. The diff coverage is 46.66%.

:exclamation: Current head 02d399f differs from pull request most recent head 4bbe0f8. Consider uploading reports for the commit 4bbe0f8 to get more accurate results

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   58.60%   60.14%   +1.53%     
==========================================
  Files         168      168              
  Lines       16256    13302    -2954     
==========================================
- Hits         9527     8000    -1527     
+ Misses       5887     4459    -1428     
- Partials      842      843       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dataproxy/service.go 60.32% <42.85%> (+2.21%) :arrow_up:
pkg/repositories/transformers/node_execution.go 75.30% <100.00%> (+2.75%) :arrow_up:

... and 153 files with indirect coverage changes

codecov[bot] avatar Jun 23 '23 23:06 codecov[bot]