flyteadmin icon indicating copy to clipboard operation
flyteadmin copied to clipboard

Refactored type casting into flyteidl

Open hamersaw opened this issue 2 years ago • 1 comments

TL;DR

To allow re-use of literal casting in other repositories this PR refactors the code into flyteidl.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [x] Unit tests added
  • [x] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

hamersaw avatar Mar 31 '23 21:03 hamersaw

Codecov Report

Merging #548 (f1dbe0a) into master (eb695b1) will increase coverage by 1.47%. The diff coverage is 100.00%.

:exclamation: Current head f1dbe0a differs from pull request most recent head 4c343ec. Consider uploading reports for the commit 4c343ec to get more accurate results

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   58.85%   60.32%   +1.47%     
==========================================
  Files         170      170              
  Lines       16068    13155    -2913     
==========================================
- Hits         9457     7936    -1521     
+ Misses       5777     4385    -1392     
  Partials      834      834              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/validation/execution_validator.go 73.80% <100.00%> (+1.73%) :arrow_up:
...g/manager/impl/validation/launch_plan_validator.go 63.54% <100.00%> (+1.55%) :arrow_up:
pkg/manager/impl/validation/signal_validator.go 81.81% <100.00%> (+2.50%) :arrow_up:
pkg/manager/impl/validation/validation.go 95.62% <100.00%> (+0.95%) :arrow_up:

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 31 '23 21:03 codecov[bot]