flyteadmin icon indicating copy to clipboard operation
flyteadmin copied to clipboard

Empty structs for task resource defaults

Open wild-endeavor opened this issue 2 years ago • 1 comments

TL;DR

Currently if you don't specify anything, these defaults will spin up pods with

      limits:
        cpu: "2"
        memory: 200Mi
      requests:
        cpu: "2"
        memory: 200Mi

Removing this will make it

    resources:
      limits:
        cpu: "0"
        memory: "0"
      requests:
        cpu: "0"
        memory: "0"

which means that there is no limit

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

wild-endeavor avatar Feb 27 '23 17:02 wild-endeavor

going to revise this. after discussing with hamersaw it feels unsafe.

wild-endeavor avatar Mar 01 '23 22:03 wild-endeavor