flyteadmin icon indicating copy to clipboard operation
flyteadmin copied to clipboard

Detailed sendgrid email error logging

Open katrogan opened this issue 3 years ago • 1 comments

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Verbose email logging on sendgrid failures

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

Tracking Issue

fixes https://github.com/flyteorg/flyte/issues/3150

Follow-up issue

NA

katrogan avatar Dec 13 '22 22:12 katrogan

Codecov Report

Merging #503 (77e25c5) into master (a1804d5) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   60.52%   60.50%   -0.02%     
==========================================
  Files         163      163              
  Lines       14492    14496       +4     
==========================================
  Hits         8771     8771              
- Misses       4955     4959       +4     
  Partials      766      766              
Flag Coverage Δ
unittests 60.50% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../notifications/implementations/sendgrid_emailer.go 67.92% <0.00%> (-5.55%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Dec 13 '22 22:12 codecov[bot]