flyteadmin icon indicating copy to clipboard operation
flyteadmin copied to clipboard

wip Fix make test

Open mayitbeegh opened this issue 3 years ago • 1 comments

Signed-off-by: Sean Lin [email protected]

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

mayitbeegh avatar Jun 02 '22 20:06 mayitbeegh

Codecov Report

Merging #437 (401fa8e) into master (6e03bd4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   61.35%   61.35%           
=======================================
  Files         156      156           
  Lines       11111    11111           
=======================================
  Hits         6817     6817           
  Misses       3589     3589           
  Partials      705      705           
Flag Coverage Δ
unittests 60.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e03bd4...401fa8e. Read the comment docs.

codecov[bot] avatar Jun 02 '22 20:06 codecov[bot]