Add support for architecture
Bump up flyteidl to add support for architecture for container/images : Ref: flyteorg/flyte#1539
Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line:
- Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
- Sign off your commits (Reference: DCO Guide).
Codecov Report
Merging #294 (f85ae7e) into Lyft-Flyte (9cc1057) will decrease coverage by
6.05%. The diff coverage is53.41%.
@@ Coverage Diff @@
## Lyft-Flyte #294 +/- ##
==============================================
- Coverage 63.19% 57.14% -6.06%
==============================================
Files 101 135 +34
Lines 7488 10136 +2648
==============================================
+ Hits 4732 5792 +1060
- Misses 2208 3697 +1489
- Partials 548 647 +99
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 55.94% <52.60%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| auth/auth_context.go | 0.00% <0.00%> (ø) |
|
| auth/config/third_party_config.go | 0.00% <0.00%> (ø) |
|
| auth/identity_context.go | 0.00% <0.00%> (ø) |
|
| auth/init_secrets.go | 0.00% <0.00%> (ø) |
|
| auth/token.go | 0.00% <0.00%> (ø) |
|
| auth/user_info_provider.go | 0.00% <0.00%> (ø) |
|
| pkg/async/notifications/email.go | 100.00% <ø> (ø) |
|
| ...async/notifications/implementations/aws_emailer.go | 100.00% <ø> (ø) |
|
| ...otifications/implementations/noop_notifications.go | 0.00% <0.00%> (ø) |
|
| ...g/async/notifications/implementations/publisher.go | 100.00% <ø> (ø) |
|
| ... and 120 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 33b902c...f85ae7e. Read the comment docs.
hey @akhurana001 just merged https://github.com/flyteorg/flyteadmin/pull/290/files which should include your idl release
oh j/k this isn't against master 😅
oh j/k this isn't against master 😅
yeah, still on a fork :( ...not sure what's going on with the test-coverage here 🤔