Aborting forever and untriggerd on_failure node when aborting failure caused by UserError

[0yukali0]

Tracking issue

flyteorg/flyte#6695

Why are the changes needed?

1. Solving Aborting forever when failure of aborting happens
2. Set on failure function in failing state node when aborting fails

What changes were proposed in this pull request?

1. Node state transfer to failing when an user error happen in Aborting and finalizing steps.
2. Exceeding max retries make the workflow state failed in order to trigger on failure node.

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

• added: For new features.
• changed: For changes in existing functionality.
• deprecated: For soon-to-be-removed features.
• removed: For features being removed.
• fixed: For any bug fixed.
• security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

• [ ] I updated the documentation accordingly.
• [ ] All new and existing tests passed.
• [ ] All commits are signed-off.

Related PRs

Docs link

[flyte-bot]

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.29%. Comparing base (74d9e86) to head (669ded2). :warning: Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6749      +/-   ##
==========================================
+ Coverage   58.57%   61.29%   +2.71%     
==========================================
  Files         929      708     -221     
  Lines       70879    42083   -28796     
==========================================
- Hits        41520    25795   -15725     
+ Misses      26206    13977   -12229     
+ Partials     3153     2311     -842     

Flag	Coverage Δ
unittests-datacatalog	60.30% <ø> (+1.27%)	:arrow_up:
unittests-flyteadmin	57.90% <ø> (+1.76%)	:arrow_up:
unittests-flytecopilot	43.16% <ø> (+1.79%)	:arrow_up:
unittests-flytectl	65.31% <ø> (+0.61%)	:arrow_up:
unittests-flyteidl	78.64% <ø> (+2.52%)	:arrow_up:
unittests-flyteplugins	62.02% <ø> (+1.01%)	:arrow_up:
unittests-flytepropeller	?
unittests-flytestdlib	64.00% <ø> (+0.94%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidmirror-ops]

@0yukali0 thanks for contributing. Any help you need?

[0yukali0]

@davidmirror-ops Thank you for your concern. I am updating tests and tracing the failed tests recently. Some failure are not in my expect, so i am going figure out where result in problems.