Allow `.tpl` of database secret names and image repository and tag
Context: Union uses flyte-core as a subchart. This pattern is likely applicable for other organizations as well.
This PR makes it so .Values.flyte.common.databaseSecret.name, *.image.repository, *.image.tag respects Helm template values through the tpl function.
Additionally, we are updating Helm version to 3.19 as it is more up to date with latest release.
- This pull request enhances the handling of database secrets in Helm templates by enabling dynamic referencing of the database secret name.
- It modifies various deployment configurations to allow the use of templated values for image references and database secret names.
- This improvement increases flexibility and configurability in secret management for deployments, allowing the secret name to be set using Helm template values.
- Overall, the changes touch on YAML configuration files and deployment configurations, introducing risks related to secret management.
Summary by Bito
- This pull request enhances the handling of database secrets in Helm templates by enabling dynamic referencing of the database secret name.
- It updates various deployment configurations to allow the use of templated values for image references and database secret names.
- The Helm version is upgraded to 3.19.0, ensuring compatibility with the latest features.
- Overall, these changes improve flexibility and configurability in secret management for deployments.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.72%. Comparing base (74d9e86) to head (16fb9a7).
:warning: Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6711 +/- ##
==========================================
+ Coverage 58.57% 59.72% +1.14%
==========================================
Files 929 929
Lines 70879 57995 -12884
==========================================
- Hits 41520 34636 -6884
+ Misses 26206 20206 -6000
Partials 3153 3153
| Flag | Coverage Δ | |
|---|---|---|
| unittests-datacatalog | 60.30% <ø> (+1.27%) |
:arrow_up: |
| unittests-flyteadmin | 57.90% <ø> (+1.76%) |
:arrow_up: |
| unittests-flytecopilot | 43.16% <ø> (+1.79%) |
:arrow_up: |
| unittests-flytectl | 65.31% <ø> (+0.61%) |
:arrow_up: |
| unittests-flyteidl | 78.64% <ø> (+2.52%) |
:arrow_up: |
| unittests-flyteplugins | 62.02% <ø> (+1.01%) |
:arrow_up: |
| unittests-flytepropeller | 55.56% <ø> (+0.50%) |
:arrow_up: |
| unittests-flytestdlib | 63.97% <ø> (+0.91%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@mhotan can you fix the conflicts?