flyte icon indicating copy to clipboard operation
flyte copied to clipboard

let helm emit available Kubernetes API versions, closes #6634

Open wildfluss opened this issue 3 months ago • 5 comments

Tracking issue

Closes #6634

Why are the changes needed?

Improve documentation

wildfluss avatar Sep 25 '25 11:09 wildfluss

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Sep 25 '25 11:09 welcome[bot]

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

flyte-bot avatar Sep 25 '25 11:09 flyte-bot

@wildfluss can you sign off your commits?

Sovietaced avatar Sep 25 '25 16:09 Sovietaced

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.57%. Comparing base (6e343cd) to head (86ab978). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6635      +/-   ##
==========================================
- Coverage   59.92%   58.57%   -1.36%     
==========================================
  Files         708      929     +221     
  Lines       51365    70907   +19542     
==========================================
+ Hits        30783    41537   +10754     
- Misses      18270    26217    +7947     
- Partials     2312     3153     +841     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.10% <ø> (-0.03%) :arrow_down:
unittests-flytecopilot 40.87% <ø> (ø)
unittests-flytectl 64.64% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.10% <ø> (ø)
unittests-flytepropeller 55.06% <ø> (?)
unittests-flytestdlib 63.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 25 '25 16:09 codecov[bot]

@wildfluss Can you also run make helm in the project root and check in the generated code?

Sovietaced avatar Sep 30 '25 15:09 Sovietaced