flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Use simplified gRPC health probe, make dynamic

Open Sovietaced opened this issue 3 months ago • 2 comments

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

Sovietaced avatar Sep 25 '25 07:09 Sovietaced

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

flyte-bot avatar Sep 25 '25 07:09 flyte-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.58%. Comparing base (6e343cd) to head (b727bfa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6633      +/-   ##
==========================================
- Coverage   59.92%   58.58%   -1.35%     
==========================================
  Files         708      929     +221     
  Lines       51365    70907   +19542     
==========================================
+ Hits        30783    41543   +10760     
- Misses      18270    26211    +7941     
- Partials     2312     3153     +841     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.13% <ø> (ø)
unittests-flytecopilot 40.87% <ø> (ø)
unittests-flytectl 64.64% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.10% <ø> (ø)
unittests-flytepropeller 55.06% <ø> (?)
unittests-flytestdlib 63.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 25 '25 07:09 codecov[bot]