Cleanup flyte propeller

[Sovietaced]

What changes were proposed in this pull request?

Cleans up unused functions, variables, redundant conditions, unused variables, string format issues, redundant type declarations.

How was this patch tested?

Unit tests

Check all the applicable boxes

• [x] I updated the documentation accordingly.
• [x] All new and existing tests passed.
• [x] All commits are signed-off.

Related PRs

Docs link

Summary by Bito

• This pull request enhances the Flyte propeller codebase by removing unused functions and variables, which may introduce risks if any of these elements were previously relied upon.
• Eliminates redundant conditions, potentially affecting code behavior if not thoroughly validated.
• Addresses string format issues and redundant type declarations, leading to improved code readability and maintainability.
• These changes improve code readability and maintainability without altering existing functionality.
• Overall summary: cleans up the Flyte propeller codebase by removing unused code and redundant elements, which introduces potential risks.

[flyte-bot]

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

[codecov[bot]]

Codecov Report

:x: Patch coverage is 57.35294% with 29 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 59.73%. Comparing base (68fc4e6) to head (c268a92). :warning: Report is 35 commits behind head on master.

Files with missing lines	Patch %	Lines
...eller/pkg/controller/nodes/array/event_recorder.go	42.85%	4 Missing :warning:
...kg/controller/nodes/subworkflow/launchplan/noop.go	50.00%	2 Missing :warning:
...er/pkg/controller/nodes/subworkflow/subworkflow.go	0.00%	2 Missing :warning:
.../nodes/task/fakeplugins/next_phase_state_plugin.go	0.00%	2 Missing :warning:
...lytepropeller/pkg/controller/nodes/task/handler.go	33.33%	2 Missing :warning:
...nodes/task/resourcemanager/noop_resourcemanager.go	50.00%	2 Missing :warning:
...propeller/pkg/controller/workflowstore/inmemory.go	0.00%	2 Missing :warning:
flytepropeller/pkg/utils/failing_datastore.go	75.00%	2 Missing :warning:
flytepropeller/events/local_writer.go	50.00%	1 Missing :warning:
...pkg/apis/flyteworkflow/v1alpha1/workflow_status.go	0.00%	1 Missing :warning:
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6516      +/-   ##
==========================================
+ Coverage   58.58%   59.73%   +1.14%     
==========================================
  Files         929      929              
  Lines       70851    57985   -12866     
==========================================
- Hits        41510    34636    -6874     
+ Misses      26194    20195    -5999     
- Partials     3147     3154       +7     

Flag	Coverage Δ
unittests-datacatalog	60.30% <ø> (+1.27%)	:arrow_up:
unittests-flyteadmin	57.86% <ø> (+1.74%)	:arrow_up:
unittests-flytecopilot	43.16% <ø> (+3.60%)	:arrow_up:
unittests-flytectl	65.36% <ø> (+0.71%)	:arrow_up:
unittests-flyteidl	78.64% <ø> (+2.52%)	:arrow_up:
unittests-flyteplugins	62.02% <ø> (+0.91%)	:arrow_up:
unittests-flytepropeller	55.61% <57.35%> (+0.55%)	:arrow_up:
unittests-flytestdlib	64.00% <ø> (+0.88%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[flyte-bot]

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].