flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Improve Logging Configuration Docs

Open Tadekola opened this issue 6 months ago • 4 comments

This PR improves the documentation for logging link configuration by:

  • Adding CloudWatch EKS Observability example
  • Clarifying template variables for dynamic log links
  • Providing a Helm escaping tip

Closes #5760

Tadekola avatar Jun 01 '25 23:06 Tadekola

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Jun 01 '25 23:06 welcome[bot]

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

flyte-bot avatar Jun 01 '25 23:06 flyte-bot

@Tadekola sorry about this. The actual content that is rendered in the docs website was moved to this repo: https://github.com/unionai/docs BTW I've been working on updating this docs too https://github.com/unionai/docs/pull/354

If you want to contribute there, that'd be great.

Sorry for the confusions

davidmirror-ops avatar Jun 03 '25 22:06 davidmirror-ops

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.51%. Comparing base (aaf6fec) to head (1dca9ed). Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6481   +/-   ##
=======================================
  Coverage   58.50%   58.51%           
=======================================
  Files         940      940           
  Lines       71582    71582           
=======================================
+ Hits        41878    41885    +7     
+ Misses      26525    26518    -7     
  Partials     3179     3179           
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.26% <ø> (+0.02%) :arrow_up:
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.72% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.08% <ø> (ø)
unittests-flytepropeller 54.78% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 06 '25 21:06 codecov[bot]

@Tadekola sorry about this. The actual content that is rendered in the docs website was moved to this repo: https://github.com/unionai/docs BTW I've been working on updating this docs too unionai/docs#354

If you want to contribute there, that'd be great.

Sorry for the confusions

Based on this and no movement for the past month I'm going to close this.

Sovietaced avatar Jun 28 '25 23:06 Sovietaced