flyte icon indicating copy to clipboard operation
flyte copied to clipboard

set reserved field in array node proto

Open pvditt opened this issue 9 months ago • 2 comments

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

pvditt avatar Mar 11 '25 08:03 pvditt

Code Review Agent Run Status

  • Limitations and other issues:  Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

flyte-bot avatar Mar 11 '25 08:03 flyte-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.39%. Comparing base (a2331bd) to head (01c17ce). :warning: Report is 173 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6324      +/-   ##
==========================================
+ Coverage   58.50%   59.39%   +0.89%     
==========================================
  Files         937      709     -228     
  Lines       71088    50344   -20744     
==========================================
- Hits        41587    29904   -11683     
+ Misses      26349    18219    -8130     
+ Partials     3152     2221     -931     
Flag Coverage Δ
unittests-datacatalog 59.06% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (-0.06%) :arrow_down:
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.00% <ø> (ø)
unittests-flytepropeller 54.79% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 11 '25 08:03 codecov[bot]