flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Fix custom gpu resource name specification

Open jeevb opened this issue 11 months ago • 3 comments

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

Summary by Bito

Implementation of configurable GPU resource names in Kubernetes configurations, replacing hardcoded NVIDIA GPU resource names. The changes focus on resource conversion utilities in the Kubernetes plugin machinery, with comprehensive test coverage added. The PR also includes Makefile improvements for development workflow enhancement.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 1

jeevb avatar Dec 29 '24 21:12 jeevb

Code Review Agent Run #d4de8b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: cb764ad..cb764ad
    • Makefile
    • flyteplugins/go/tasks/pluginmachinery/flytek8s/utils.go
    • flyteplugins/go/tasks/pluginmachinery/flytek8s/utils_test.go
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • GOVULNCHECK (Security Vulnerability) - ✖︎ Failed
    • SNYK (Security Vulnerability) - ✔︎ Successful
    • OWASP (Security Vulnerability) - ✔︎ Successful

AI Code Review powered by Bito Logo

flyte-bot avatar Dec 29 '24 21:12 flyte-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 37.01%. Comparing base (61838b4) to head (cb764ad). :warning: Report is 262 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6129   +/-   ##
=======================================
  Coverage   37.01%   37.01%           
=======================================
  Files        1318     1318           
  Lines      132525   132526    +1     
=======================================
+ Hits        49052    49055    +3     
+ Misses      79228    79226    -2     
  Partials     4245     4245           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.25% <ø> (+0.02%) :arrow_up:
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (-0.05%) :arrow_down:
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.86% <100.00%> (+<0.01%) :arrow_up:
unittests-flytepropeller 42.59% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 29 '24 21:12 codecov[bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - GPU Resource Name Configuration Enhancement

utils.go - Modified GPU resource name to be configurable instead of hardcoded

utils_test.go - Added test cases for custom GPU resource name configuration

Other Improvements - Development Workflow Enhancement

Makefile - Added run target for local development with single binary configuration

flyte-bot avatar Dec 29 '24 21:12 flyte-bot