flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Core feature] Surface pod template mis-configuration in the UI.

Open thomasjpfan opened this issue 1 year ago • 6 comments

Motivation: Why do you think this is important?

When working with PodTemplates any misconfiguration do not show up in the UI. The UI only shows "pending". The only way to debug it is to see the propeller logs.

Goal: What should the final outcome look like, ideally?

The errors related to pod template misconfiguration are show in the UI.

Describe alternatives you've considered

We can also do the same type of validation on the client side so we error early.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

thomasjpfan avatar Dec 26 '24 18:12 thomasjpfan

Let's investigate two (complementary) approaches:

  1. validate podspec at registration time in flytekit
  2. Use https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core/validation to validate podspecs in flyteadmin

eapolinario avatar Dec 26 '24 18:12 eapolinario

#take

kevinliao852 avatar Jan 03 '25 19:01 kevinliao852

Hey @kevinliao852 I was wondering if you had any questions?

davidmirror-ops avatar Feb 04 '25 16:02 davidmirror-ops

Hey @davidmirror-ops , I just saw this message—sorry for the late reply! I previously discussed this with @pingsutw , and he suggested that adding the check in FlyteKit may not be necessary, so I’ve been focusing on FlyteAdmin instead. I’ve been looking into how validation can be best implemented there.

Do you have any thoughts on the approach for handling this validation? I'd appreciate any insights!

kevinliao852 avatar Mar 08 '25 09:03 kevinliao852

Contributor's sync notes: once the bump to go 1.23 is merged, we can go back to use the validation library in flyteadmin

davidmirror-ops avatar Mar 13 '25 14:03 davidmirror-ops

"Hello 👋, this feature request has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 14 days. Thank you for your contribution and understanding! 🙏"

github-actions[bot] avatar Dec 09 '25 00:12 github-actions[bot]

I believe this issue is now unblocked because Go has already been upgraded to version 1.24.

kevinliao852 avatar Dec 19 '25 06:12 kevinliao852