flyteorg
[RFC] Flyte Admin RBAC + Project/Domain Isolation
Tracking issue
Related to https://github.com/flyteorg/flyte/issues/5189 Related to https://github.com/flyteorg/flyte/issues/4622
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 36.71%. Comparing base (bdaf79f) to head (ef505e2).
:warning: Report is 325 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5871 +/- ##
=======================================
Coverage 36.71% 36.71%
=======================================
Files 1304 1304
Lines 130081 130081
=======================================
Hits 47764 47764
Misses 78147 78147
Partials 4170 4170
| Flag | Coverage Δ | |
|---|---|---|
| unittests-datacatalog | 51.58% <ø> (ø) |
|
| unittests-flyteadmin | 54.41% <ø> (ø) |
|
| unittests-flytecopilot | 11.73% <ø> (ø) |
|
| unittests-flytectl | 62.40% <ø> (ø) |
|
| unittests-flyteidl | 6.89% <ø> (ø) |
|
| unittests-flyteplugins | 53.62% <ø> (ø) |
|
| unittests-flytepropeller | 42.84% <ø> (ø) |
|
| unittests-flytestdlib | 54.78% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
2024-11-7 Contributor's sync notes: Jason introduced the proposal and expects to work on the implementation as a feature gate. Community feedback is important to learn how the community is using providers other than Okta to handle authz and groups.
What's the current status of the proposal?
I am working through an initial pull request to add this functionality.
What's the current status of the proposal?
I am working through an initial pull request to add this functionality.
That's cool and I am happy to have a look! What about the TSC evaluation phases? I have seen other posts where RBAC was dismissed...
That's cool and I am happy to have a look! What about the TSC evaluation phases? I have seen other posts where RBAC was dismissed...
I'm not familiar with the TSC evaluation phase but everyone is eager for this to get over the line.
I have completed an initial implementation. Please take a look: https://github.com/flyteorg/flyte/pull/6190
While the PR awaits review a few folks have checked it out in their forks and have got it working so feel free to try it out and provide feedback on the ux.
Acceptance of this proposal is contingent on the consolidation of SIG-RBAC with the scope proposed here
Hi, I was wondering what's missing to get forward and merge the PR? We absolutely would love this feature, which is required for us to adopt flyte.
Hi, I was wondering what's missing to get forward and merge the PR? We absolutely would love this feature, which is required for us to adopt flyte.
@davidmirror-ops ?