flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Remove duplicate recovery interceptor

Open Sovietaced opened this issue 1 year ago • 1 comments

Tracking issue

While working on an RFC I noticed that there is a duplicate recovery interceptor installed inside the Flyte Admin server. We ideally want to use the custom one which ties into metrics.

Sovietaced avatar Oct 19 '24 21:10 Sovietaced

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.71%. Comparing base (bdaf79f) to head (66c8c8e). Report is 154 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5870      +/-   ##
==========================================
- Coverage   36.71%   36.71%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      130081   130079       -2     
==========================================
- Hits        47764    47758       -6     
- Misses      78147    78151       +4     
  Partials     4170     4170              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.39% <ø> (-0.03%) :arrow_down:
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.89% <ø> (ø)
unittests-flyteplugins 53.62% <ø> (ø)
unittests-flytepropeller 42.84% <ø> (ø)
unittests-flytestdlib 54.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 19 '24 21:10 codecov[bot]