flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Update helm/docs per changes in supported task discovery

Open Sovietaced opened this issue 1 year ago • 2 comments

Why are the changes needed?

These changes aren't strictly needed but they simplify configuration based on the changes introduced in https://github.com/flyteorg/flyte/pull/5460

What changes were proposed in this pull request?

Removes explicit configuration supported task types since they are now automatically discovered.

How was this patch tested?

See generated helm

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

Sovietaced avatar Aug 26 '24 19:08 Sovietaced

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.17%. Comparing base (7a91799) to head (cefad53). Report is 155 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   36.17%   36.17%   -0.01%     
==========================================
  Files        1303     1303              
  Lines      109663   109663              
==========================================
- Hits        39667    39666       -1     
- Misses      65851    65852       +1     
  Partials     4145     4145              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.28% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.18% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.76% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '24 19:08 codecov[bot]

Pinging @davidmirror-ops since he has more expertise in the helm charts & deployment docs than me or Peeter.

neverett avatar Aug 26 '24 20:08 neverett

here's some todo:

  1. solve the merged conflict
  2. before we merge it, we have to build an image of flyte and test it. go to this folder and run make build https://github.com/flyteorg/flyte/tree/master/docker/sandbox-bundled

if possible, please run a sensor task and provide screenshot that new image works! https://docs.flyte.org/en/latest/flytesnacks/examples/sensor/file_sensor_example.html

I have updated the PR description and seems that I was able to get the task running, but not sure how to satisfy the sensor so the task completes. But I can verify that propeller identifies the agent-service for the task type.

Sovietaced avatar Aug 31 '24 00:08 Sovietaced

I've built the image and test it.

image image image

Future-Outlier avatar Sep 03 '24 04:09 Future-Outlier