flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Docs] auth setup page issues

Open davidmirror-ops opened this issue 1 year ago • 5 comments

Description

We need to fix the following problems for the auth setup docs to be more precise:

  1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI
  2. The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):
configmap:
  adminServer:
    server:
      httpPort: 8088
      grpc:
        port: 8089
      security:
        secure: false
        useAuth: true
        allowCors: true
        allowedOrigins:
 # Accepting all domains for Sandbox installation
          - "*"
        allowedHeaders:
          - "Content-Type"
  1. Step 8 and beyond are folded inside the Note block when it should be out
  2. There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

davidmirror-ops avatar Jul 10 '24 20:07 davidmirror-ops

Issue Title: [Docs] auth setup page issues

Issue Body:

Description

We need to fix the following problems for the auth setup docs to be more precise:

  1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI.
  2. The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):
configmap:
  adminServer:
    server:
      httpPort: 8088
      grpc:
        port: 8089
      security:
        secure: false
        useAuth: true
        allowCors: true
        allowedOrigins:
          # Accepting all domains for Sandbox installation
          - "*"
        allowedHeaders:
          - "Content-Type"
  1. Step 8 and beyond are folded inside the Note block when it should be out.
  2. There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @runllm to ask follow-up questions. See runllm.com for more!

runllm[bot] avatar Jul 10 '24 20:07 runllm[bot]

Additional findings:

a. Step 3 for flyte-core in the Apply OIDC Configuration section should be changed from manually editing the flyteadmin secret to just adding the following to the values:

flyte-core

flyteadmin:
  secrets:
    oidc_client_secret: <client_secret_from_your_IDP>

davidmirror-ops avatar Sep 10 '24 15:09 davidmirror-ops

@davidmirror-ops I would love to contribute to this issue, Can you please assign this to me ? 🙌

Murdock9803 avatar Oct 04 '24 05:10 Murdock9803

@Murdock9803 looking forward to your contributions!

davidmirror-ops avatar Oct 04 '24 10:10 davidmirror-ops

Hi I have fixed the issues, please review and give me feedback. I hope it isn't an problem that I wasn't assigned this issue.

pranshustuff avatar Oct 18 '24 14:10 pranshustuff