flyte icon indicating copy to clipboard operation
flyte copied to clipboard

add execution_version to ArrayNode proto

Open pvditt opened this issue 1 year ago • 1 comments

Why are the changes needed?

Support toggling between subnode store and retain backwards compatibility.

What changes were proposed in this pull request?

Add execution_version to ArrayNode proto

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

Docs link

pvditt avatar Jun 26 '24 06:06 pvditt

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 35.90%. Comparing base (337088e) to head (84c4e42). Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 4.76% 20 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5512       +/-   ##
===========================================
- Coverage   60.98%   35.90%   -25.09%     
===========================================
  Files         796     1301      +505     
  Lines       51676   109419    +57743     
===========================================
+ Hits        31515    39287     +7772     
- Misses      17261    66035    +48774     
- Partials     2900     4097     +1197     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (-17.95%) :arrow_down:
unittests-flyteadmin 53.73% <ø> (-5.00%) :arrow_down:
unittests-flytecopilot 12.17% <ø> (-5.62%) :arrow_down:
unittests-flytectl 62.28% <ø> (-5.16%) :arrow_down:
unittests-flyteidl 7.09% <4.76%> (-71.98%) :arrow_down:
unittests-flyteplugins 53.31% <ø> (-8.46%) :arrow_down:
unittests-flytepropeller 41.75% <ø> (-15.73%) :arrow_down:
unittests-flytestdlib 55.27% <ø> (-10.42%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 06:06 codecov[bot]