flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Inherit execution cluster label from source execution

Open va6996 opened this issue 1 year ago • 1 comments

Tracking issue

Today if a user creates an execution with the execution-cluster-label, then the execution launches in the specified cluster. However, if the workflow has a reference workflow in the workflow, that reference workflow launches in the default cluster since this information isn't passed along. This change fixes that issue by inheriting the cluster label from the source.

Why are the changes needed?

Without this change, part of the workflow will run in cluster 1 and part in cluster 2.

How was this patch tested?

In a local cluster, a workflow was launched with a reference workflow and the reference workflow launched in the correct cluster.

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

va6996 avatar May 29 '24 22:05 va6996

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar May 29 '24 22:05 welcome[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.08%. Comparing base (25c3596) to head (33eb707). Report is 147 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5431   +/-   ##
=======================================
  Coverage   61.07%   61.08%           
=======================================
  Files         793      793           
  Lines       51226    51229    +3     
=======================================
+ Hits        31288    31291    +3     
  Misses      17062    17062           
  Partials     2876     2876           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.91% <100.00%> (+<0.01%) :arrow_up:
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 31 '24 03:05 codecov[bot]

Congrats on merging your first pull request! 🎉

welcome[bot] avatar Jun 20 '24 10:06 welcome[bot]